lukas/kata

Fork 0

Add proper memoize integration #21

Closed

lukas wants to merge 0 commits from feat-memoize into main

lukas commented

2026-03-30 11:08:14 +00:00

Owner

solves #6

lukas self-assigned this

2026-03-30 11:08:14 +00:00

lukas added 3 commits

2026-03-30 11:08:14 +00:00

relevant styles add themselves to the memoize context when used fac53dbc4d

add package version, kataStepCnt and step counter value to context d06d2c4a16

fixup typo b3081e5c41

lukas commented

2026-03-30 11:12:17 +00:00

Author

Owner

Analysis of the generated memos when typesetting the Extended Example (plus a simple tikzpicture):

5 externs generated (4 steps + 1 tikzpicture) ✅
context of the tikzpicture is unaltered ✅

\mmzResource{main.13CA6225EF1CB8B2D15D71140C2A246B-E778DCCCB8AAB0BBD3F6CFEEFD2421F8.pdf}%
\mmzMemo
\quitvmode \mmzIncludeExtern {0}\hbox {21.94595pt}{13.71594pt}{0.0pt}{72.26999pt}{72.26999pt}{72.26999pt}{72.26999pt}\mmzStepPgfPictureId {1}%
\mmzThisContext
padding=(1in,1in,1in,1in),
\mmzEndMemo

Other contexts:

padding=(1in,1in,1in,1in),stepCnt->3,kata version->0.1.0,,kataStepCnt code={\protected macro:#1->\arabic {#1}},pgfk@/tikz/head/.@cmd,pgfk@/tikz/stance/.@cmd,pgfk@/tikz/stance label/.@cmd,pgfk@/tikz/stance label base/.@cmd,pgfk@/tikz/waza/.@cmd,pgfk@/tikz/waza label/.@cmd,pgfk@/tikz/waza label base/.@cmd,pgfk@/tikz/border/.@cmd,pgfk@/tikz/step counter/.@cmd,
padding=(1in,1in,1in,1in),stepCnt->0,kata version->0.1.0,,kataStepCnt code={\protected macro:#1->\arabic {#1}},pgfk@/tikz/head/.@cmd,pgfk@/tikz/stance/.@cmd,pgfk@/tikz/stance label/.@cmd,pgfk@/tikz/stance label base/.@cmd,pgfk@/tikz/waza/.@cmd,pgfk@/tikz/waza label/.@cmd,pgfk@/tikz/waza label base/.@cmd,pgfk@/tikz/dir/.@cmd,pgfk@/tikz/border/.@cmd,pgfk@/tikz/step counter/.@cmd,
padding=(1in,1in,1in,1in),stepCnt->1,kata version->0.1.0,,kataStepCnt code={\protected macro:#1->\arabic {#1}},pgfk@/tikz/head/.@cmd,pgfk@/tikz/stance/.@cmd,pgfk@/tikz/stance label/.@cmd,pgfk@/tikz/stance label base/.@cmd,pgfk@/tikz/waza/.@cmd,pgfk@/tikz/waza label/.@cmd,pgfk@/tikz/waza label base/.@cmd,pgfk@/tikz/dir/.@cmd,pgfk@/tikz/border/.@cmd,pgfk@/tikz/step counter/.@cmd,
padding=(1in,1in,1in,1in),stepCnt->2,kata version->0.1.0,,kataStepCnt code={\protected macro:#1->\arabic {#1}},pgfk@/tikz/head/.@cmd,pgfk@/tikz/stance/.@cmd,pgfk@/tikz/stance label/.@cmd,pgfk@/tikz/stance label base/.@cmd,pgfk@/tikz/waza/.@cmd,pgfk@/tikz/waza label flipped/.@cmd,pgfk@/tikz/waza label base/.@cmd,pgfk@/tikz/dir/.@cmd,pgfk@/tikz/border/.@cmd,pgfk@/tikz/step counter/.@cmd,

width=3 might require drawing multiple phantom steps -> all use the same extern ✅

Analysis of the generated `memo`s when typesetting the *Extended Example* (plus a simple tikzpicture): 1. 5 externs generated (4 `step`s + 1 `tikzpicture`) ✅ 2. context of the `tikzpicture` is unaltered ✅ ```tex \mmzResource{main.13CA6225EF1CB8B2D15D71140C2A246B-E778DCCCB8AAB0BBD3F6CFEEFD2421F8.pdf}% \mmzMemo \quitvmode \mmzIncludeExtern {0}\hbox {21.94595pt}{13.71594pt}{0.0pt}{72.26999pt}{72.26999pt}{72.26999pt}{72.26999pt}\mmzStepPgfPictureId {1}% \mmzThisContext padding=(1in,1in,1in,1in), \mmzEndMemo ``` 3. Other contexts: ```tex padding=(1in,1in,1in,1in),stepCnt->3,kata version->0.1.0,,kataStepCnt code={\protected macro:#1->\arabic {#1}},pgfk@/tikz/head/.@cmd,pgfk@/tikz/stance/.@cmd,pgfk@/tikz/stance label/.@cmd,pgfk@/tikz/stance label base/.@cmd,pgfk@/tikz/waza/.@cmd,pgfk@/tikz/waza label/.@cmd,pgfk@/tikz/waza label base/.@cmd,pgfk@/tikz/border/.@cmd,pgfk@/tikz/step counter/.@cmd, padding=(1in,1in,1in,1in),stepCnt->0,kata version->0.1.0,,kataStepCnt code={\protected macro:#1->\arabic {#1}},pgfk@/tikz/head/.@cmd,pgfk@/tikz/stance/.@cmd,pgfk@/tikz/stance label/.@cmd,pgfk@/tikz/stance label base/.@cmd,pgfk@/tikz/waza/.@cmd,pgfk@/tikz/waza label/.@cmd,pgfk@/tikz/waza label base/.@cmd,pgfk@/tikz/dir/.@cmd,pgfk@/tikz/border/.@cmd,pgfk@/tikz/step counter/.@cmd, padding=(1in,1in,1in,1in),stepCnt->1,kata version->0.1.0,,kataStepCnt code={\protected macro:#1->\arabic {#1}},pgfk@/tikz/head/.@cmd,pgfk@/tikz/stance/.@cmd,pgfk@/tikz/stance label/.@cmd,pgfk@/tikz/stance label base/.@cmd,pgfk@/tikz/waza/.@cmd,pgfk@/tikz/waza label/.@cmd,pgfk@/tikz/waza label base/.@cmd,pgfk@/tikz/dir/.@cmd,pgfk@/tikz/border/.@cmd,pgfk@/tikz/step counter/.@cmd, padding=(1in,1in,1in,1in),stepCnt->2,kata version->0.1.0,,kataStepCnt code={\protected macro:#1->\arabic {#1}},pgfk@/tikz/head/.@cmd,pgfk@/tikz/stance/.@cmd,pgfk@/tikz/stance label/.@cmd,pgfk@/tikz/stance label base/.@cmd,pgfk@/tikz/waza/.@cmd,pgfk@/tikz/waza label flipped/.@cmd,pgfk@/tikz/waza label base/.@cmd,pgfk@/tikz/dir/.@cmd,pgfk@/tikz/border/.@cmd,pgfk@/tikz/step counter/.@cmd, ``` 4. `width=3` might require drawing multiple phantom steps -> all use the same extern ✅

lukas commented

2026-03-30 11:14:34 +00:00

Author

Owner

is pgfk@/tikz/head/.@cmd, an issue? (does not seem to contain the full style (or is this only a matter of display?)

is `pgfk@/tikz/head/.@cmd,` an issue? (does not seem to contain the full style (or is this only a matter of display?)

lukas added 1 commit

2026-03-30 11:27:34 +00:00

use fully qualified paths when using meaning to context to avoid adding wrong keys 1e48513e07

lukas commented

2026-03-30 11:31:24 +00:00

Author

Owner

Yes the issue is the following:

\pgfkeys{
  /foo/.cd,
  bar/.style{bar/.meaning to context},
}
\tikz \node[/foo/bar] {};

now the handler .meaning to context is executed on the /tikz/bar key (which is empty) instead on the /foo/bar key.
(would have been evident based on the "key-name/-path" shown in the context printed in the .memo file

Yes the issue is the following: ```tex \pgfkeys{ /foo/.cd, bar/.style{bar/.meaning to context}, } \tikz \node[/foo/bar] {}; ``` now the handler `.meaning to context` is executed on the `/tikz/bar` key (which is empty) instead on the `/foo/bar` key. (would have been evident based on the "key-name/-path" shown in the context printed in the `.memo` file

lukas referenced this pull request

2026-03-30 11:51:36 +00:00

memoize adjustments #6

lukas added 2 commits

2026-03-30 20:00:12 +00:00

parametrize the package version (and date) to have a single point of truth 6d81513e3f

dtxtut says dates should be given as YYYY-MM-DD instead of YYYY/MM/DD 40acd26796

lukas added 2 commits

2026-03-31 10:56:11 +00:00

don't implicitly depend on etoolbox, instead use latex's own (new) hooking system bb09ee24fb

load memoizable instead of manually defining no-op handlers fd3638ca38

lukas added 2 commits

2026-03-31 16:07:51 +00:00

add a section about memoization to the docs eaf932e589

directly set up memoize integration (no hook), memoize itself requires to be loaded before memoization-aware packages 63dacf7aee

lukas added 1 commit

2026-03-31 16:38:56 +00:00

add macros storing colors to the context f7ebf6c534

lukas commented

2026-03-31 22:02:45 +00:00

Author

Owner

Additional issues that came up:

memoize should always be loaded before the custom package (as specified by the memoize docs)
adding \kata@color@* to the context was missing
adding the package version to the context was still missing
use memoizable instead of manually defining stubs

merging tomorrow

Additional issues that came up: 1. `memoize` should always be loaded before the custom package (as specified by the `memoize` docs) 2. adding `\kata@color@*` to the context was missing 3. adding the package version to the context was still missing 4. use `memoizable` instead of manually defining stubs merging tomorrow

lukas commented

2026-04-01 10:40:11 +00:00

Author

Owner

manually merged in 08c107e (regenerated kata.pdf to fixup the conflict -> no automatic merge / no detection of the merge)

manually merged in 08c107e (regenerated `kata.pdf` to fixup the conflict -> no automatic merge / no detection of the merge)

lukas closed this pull request

2026-04-01 10:40:13 +00:00

lukas deleted branch feat-memoize

2026-04-01 10:40:21 +00:00